DATA-3948 Update CLI to use new binary data id type #4879
Merged
vijayvuyyuru merged 4 commits intoviamrobotics:mainfrom Apr 10, 2025
Merged
DATA-3948 Update CLI to use new binary data id type #4879vijayvuyyuru merged 4 commits intoviamrobotics:mainfrom
vijayvuyyuru merged 4 commits intoviamrobotics:mainfrom
Conversation
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
gloriacai01
reviewed
Apr 7, 2025
cli/app.go
Outdated
| @@ -1261,7 +1251,7 @@ var app = &cli.App{ | |||
| Name: "add", | |||
| Usage: "adds tags to binary data by file ids for a given org and location", | |||
Member
There was a problem hiding this comment.
[nit] for the usage text of these can we also say binary data IDs? i think it can get a little confusing when it says file ids in the description sometimes but the flag usage text says binary data IDs
Member
Author
There was a problem hiding this comment.
Good call, will change
cli/app.go
Outdated
| Name: dataFlagFileIDs, | ||
| Usage: "comma separated file IDs of data belonging to specified org and location", | ||
| Name: dataFlagBinaryDataIDs, | ||
| Usage: "comma separated binary data IDs of data belonging to specified org and location", |
Member
There was a problem hiding this comment.
we dont specify the org and location in the cli here anymore so i guess we can remove that part of the description? wdyt?
viambot
added
safe to test
njooma
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.